A provider of financial services to military members has sold a controlling stake in USAA Real Estate, an investment firm that often co-invests with pension funds.